Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup exchange #528

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Cleanup exchange #528

merged 3 commits into from
Mar 11, 2022

Conversation

Janaka-Steph
Copy link
Collaborator

@Janaka-Steph Janaka-Steph commented Mar 10, 2022

  • Simplify updateReceiveSats and updateSendSats in src/components/TdexOrderInput/hooks.ts
  • Use IonAlert as a component to have simpler code and fix edge cases
  • Hide "Market provided by: ..." if sendSats is zero
  • New action replaceMarketsOfProvider instead of addMarkets to update properly when provider/markets goes down. Also simpler code
  • Log createDiscoverer errors
  • Fix getMarketsFromProvider retry (not catching in fn)

Please review @tiero

@tiero tiero merged commit e47f388 into tdex-network:master Mar 11, 2022
@Janaka-Steph Janaka-Steph deleted the refacto-exchange branch March 15, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants